[PATCH cygport] Increase _FORTIFY_SOURCE level from 2 to 3 in CFLAGS

Jon Turney jon.turney@dronecode.org.uk
Sun Feb 11 17:04:15 GMT 2024


On 04/02/2024 16:30, Christian Franke via Cygwin-apps wrote:
> Jon Turney wrote:
>> On 02/02/2024 16:13, Christian Franke via Cygwin-apps wrote:
>>> _FORTIFY_SOURCE=3 is supported by Cygwin 3.5.0 headers and Cygwin gcc 
>>> 13.2.1 test release.
>>>
>>> Silently falls back to level 2 if level 3 is unsupported (older 
>>> headers or gcc) or to level 0 if unsupported at all (C++, clang).
>>
>> Thanks. I applied this.
>>
>> I'm thinking I want to try to do another cygport release fairly 
>> soonish, so please feel free to remind me about any other patches by 
>> you (or others) which I need to look at before then.
>>
> 
> Possibly some initial SOURCE_DATE_EPOCH support:
> https://sourceware.org/pipermail/cygwin-apps/2023-August/043108.html

I've applied this (and I think I might have caught up on most of the 
pending patches...)

It would be nice to have some sort of test, since there's no coverage 
with SOURCE_DATE_EPOCH defined at the moment.

Even if we just verify that an existing test continues to build without 
problems with it defined, that would be a good start, let alone 
verifying that it actually sets timestamps as expected...



More information about the Cygwin-apps mailing list