Remove legacy networking code
Jon Turney
jon.turney@dronecode.org.uk
Sun Jan 28 21:47:00 GMT 2018
On 26/01/2018 16:56, SZAVAI Gyula wrote:
> [PATCH setup 1/5] Remove direct(legacy) connection type
> [PATCH setup 2/5] Rename IDC_NET_IE5 to IDC_NET_PRECONFIG
> [PATCH setup 3/5] Remove NetIO_File
> [PATCH setup 4/5] Add Proxy class
> [PATCH setup 5/5] Remove NetIO_HTTP
Thanks, this is great.
A few minor comments:
1/5:
It would be nice if you'd said in the patch commentary what will happen
to existing installations which are configured to use direct(legacy) -
they get converted to preconfig.
3/5:
This changes to wininet handling all file access (converting raw paths
into file:// format URLs)
I had some concerns [1] that this maybe changes the set of malformed
file:// URLs we handle (which is ok, although it would be nice to know
the details), and still doesn't handle correctly formed ones.
[1] https://cygwin.com/ml/cygwin-apps/2017-05/msg00117.html
4/5:
operator!= could probably use a comment along the lines of "it's only
meaningful to compare host:port if IDC_NET_PROXY"
It's unclear to me what Proxy::bypass() is doing. MSDN actually says
"Do not use an empty string", for unclear reasons.
We can also remove simpsock.{cc,h} and linking with winsock, after this
series.
More information about the Cygwin-apps
mailing list