[PATCH setup 00/13] ListView Package Chooser

[Ken Brown]

On 8/5/2018 6:08 PM, Jon Turney wrote:
> Drag setup into the 1990s, by replacing the custom-drawn package chooser
> with a ListView common control.
> 
> As well as removing a lot of Win32 GDI drawing, this also enables the
> following improvements to be much more straightforward:
> 
> * Use standard UI elements to choose an action to take on a package or
> category, rather than the weird UX of clicking to cycle around a list of
> options of undisclosed length.

This is a huge improvement over the existing UX.

> * Add tooltips (initially, the ldesc as a tooltip for sdesc)

This is also a big improvement.  It's nice to see ldesc finally being used.

I have one minor fix (patch attached) and one suggestion: It would be 
good, if possible, for setup to remember the column widths if the user 
changes them, just as it now remembers the size and position of the 
chooser window.

Thanks for doing this.  It must have been a lot of work.

Ken
-------------- next part --------------
From bd16602c08e6edba7ef7f91b149a8e9a0fe45587 Mon Sep 17 00:00:00 2001
From: Ken Brown <kbrown@cornell.edu>
Date: Mon, 6 Aug 2018 10:05:12 -0400
Subject: [PATCH] Ensure that an installed packageversion has an ldesc if
 possible

In packagedb::read(), copy the ldesc from setup.ini to the
packageversion read from installed.db.  Otherwise, an installed
package with only one version will not have an ldesc to use as a
tooltip.
---
 package_db.cc | 1 +
 1 file changed, 1 insertion(+)

diff --git a/package_db.cc b/package_db.cc
index b74aafd..9aa3b8e 100644
--- a/package_db.cc
+++ b/package_db.cc
@@ -149,6 +149,7 @@ packagedb::read ()
                   if (pv)
                     {
                       data.sdesc = pv.SDesc();
+                      data.ldesc = pv.LDesc();
                       data.archive = *pv.source();
                       data.stability = pv.Stability();
                       data.spkg_id = pv.sourcePackage();
-- 
2.17.0