[PATCH setup 0/5] Improve behavior after download error, v2
Jon Turney
jon.turney@dronecode.org.uk
Mon Nov 13 11:51:00 GMT 2017
On 10/11/2017 14:43, Ken Brown wrote:
> Currently setup goes back to the mirror selection page after a
> download error if the user answers "Yes" to "Download incomplete. Try
> again?". The same happens in unattended mode until the retries have
> been exhausted.
>
> And if the user answers "No", then installation continues, even though
> this can damage the user's installation. For example, if a package is
> selected for reinstall but cannot be downloaded, it will be
> uninstalled.
>
> This series of patches changes the behavior as follows:
>
> - In unattended mode, simply retry the download.
>
> - In interactive mode, pop up a dialog showing which packages had
> download errors and giving the user the following options:
> - Retry (retries download)
> - Back (return to the package selection page)
> - Continue, with a warning
> - Cancel (exit)
Thanks. This looks great. Please apply to master.
> Ken Brown (5):
> Just retry download after error in unattended mode
> Fix off-by-one error in download retry report
> Remove "Try again?" from exit message.
> Query user after download error in interactive mode
> Limit the number of packages shown in the IDD_DOWNLOAD_ERROR listbox
You can drop this last one. I don't think you need to limit the list if
we have a scrollable textbox to show it in.
I was just pointing out that the list could be large, because I was
assuming use of a MessageBox(), but you've sidestepped that since you
are using a custom dialog.
More information about the Cygwin-apps
mailing list