[PATCH] src_postinst.cygpart: Sanitize binary data in bash command subst

Yaakov Selkowitz yselkowitz@cygwin.com
Tue Jan 17 23:02:00 GMT 2017


On 2016-12-16 15:09, Eric Blake wrote:
> On 12/16/2016 02:40 PM, Eric Blake wrote:
>> bash 4.4 now warns about skipping NUL bytes in $(command), since
>> command substitution is only well-formed for commands that output
>> text, but NUL bytes are not text.  Silence the warning by removing
>> NUL bytes from the stream before bash can see them.
>
> And of course, reading this in isolation, we could shave a process or
> two by merging the two case statements into one, if you want to go one
> step further as a micro-optimization:

Squashed and pushed.  Thanks,

-- 
Yaakov



More information about the Cygwin-apps mailing list