[PATCH setup 0/4] Use a pop-up menu to select chooser view filter

[Jon Turney]

On 26/08/2016 16:25, Corinna Vinschen wrote:
> On Aug 26 15:41, Jon Turney wrote:
>> On 26/08/2016 09:07, Corinna Vinschen wrote:
>>> On Aug 25 15:34, Yaakov Selkowitz wrote:
>>>> On 2016-08-25 14:11, Jon Turney wrote:
>>>>> On 24/08/2016 17:50, Corinna Vinschen wrote:
>>>>>> One question: Usually the popup menu itself reflects the current choice.
>>>>>> So, wouldn't it make more sense to have the text "View" just as plain
>>>>>> text to the left, and the actual popup menu next right to it, showing
>>>>>> the current choice?  Yes?  No?  Shut up?
>>>>>
>>>>> Yeah, there is probably better visual language to be used here.
>>>>>
>>>>> If the popup menu itself reflects the current choice, perhaps we don't
>>>>> need a caption with the current choice at all (i.e. just a button that
>>>>> says "View" and that's all...)
>>>>>
>>>>> I'd really like that button to have a 'â–¾' to indicate it has a
>>>>> drop-down, but that seems hard to achieve.
>>>>>
>>>>> (This might be done with the BS_SPLITBUTTON style (which combines a
>>>>> button and dropdown menu), but that is sadly only supported by common
>>>>> controls on Vista or later.)
>>
>> Two more patches follow this mail, which do that.
>>
>> I'm still not totally happy with this.  It could give the impression that
>> something is supposed to happen when the "View" part of the the button is
>> clicked, and there is no keyboard shortcut to open the view selection menu.
>
> Looks like I didn't explain well enough what I meant.  What I had in
> mind was a pull-down menu just as you did, but which reflects the
> current state in its text.  The word "View" would just show up in fixed
> text field left of it.  I. e.:
>
>          +--------------------+
>    View: | Category       | v |
>          +--------------------+
>
> After the user chooses "Pending":
>
>          +--------------------+
>    View: | Pending        | v |
>          +--------------------+
>
> I think this is what most users expect from this pull-down menu style,
> isn't it?

Ah, right.  Using a drop-down list is the correct thing to do here.

I had the idea in the back of my mind that in future it might be 
worthwhile to add other actions here (e.g. expand/collapse all in 
category view, unpacking the fixed filter set we support into the tests 
they are composed of, etc.), where a menu would be more appropriate, but 
I guess we can cross that bridge if we get to it...

See the replacement [4/4] to follow this mail.