[PATCH setup] (Usability improvement) Implement half-second wait for user to finish typing before searching packages

Thomas Wolff towo@towo.net
Tue Aug 2 10:02:00 GMT 2016


Am 02.08.2016 um 11:22 schrieb Corinna Vinschen:
> On Aug  1 23:17, Ronald Ramos wrote:
>> commit 357c1e7576586349efb8514dc9d8d03950e225ee
>> Author: Ronald Ramos <ronjoe223@gmail.com>
>> Date:   Mon Aug 1 23:05:44 2016 -0400
>>
>>      * proppage.h (PropertyPage)
>>          New member OnTimerMessage (delegates similarly to OnMouseWheel)
>>
>>      * proppage.cc
>>          (DialogProc) Added handling of WM_TIMER
>>
>>      * choose.h (ChooserPage)
>>          (OnTimerMessage) New function prototype
>>          (timer_id) New member variable
>>          Added DEFINE-ed default values for timer_id and search timer delay
>>          Reorganized private members for consistency
>>
>>      * choose.cc
>>          (constructor) Initialize timer_id
>>          (OnMessageCmd) Replaced search-refresh with a SetTimer
>>          (OnSearchTimer) New; contains search-refresh removed from
>> OnMessageCmd
> Neat!  Applied.  Personally I would rather see a shorter timeout like,
> say, 300ms, but I guess we shouldn't take for granted that everybody is
> typing fast.  Even with 500ms timeout it's now much more convenient than
> the old "search after each keypress" method.
I agree with Corinna. Great enhancement, but 300ms should be a good 
trade-off for unpatient people...
Thomas



More information about the Cygwin-apps mailing list