setup

[Corinna Vinschen]

On Jun 12 19:05, Achim Gratz wrote:
> Corinna Vinschen writes:
> > "known good" == -m?
> 
> Yes.
> 
> > Thank you for getting rid of IniParseFindVisitor :)
> 
> I wasn't all that sure about this, but it simply made no sense to me for
> the task at hand.
> 
> > However, IniParseFindVisitor searched the tree for ini files, so, does
> > the new code still work for the standard local install with ini files
> > copied from various mirrors, w/o -m option?  It seems the answer is yes
> > (you're iterating over the site list), but it would be helpful if this
> > had been tested.
> 
> What's the expected directory structure here?

In the usual case ("Install from Internet") the local package directory
contains a separate subdir for each mirror chosen from the mirror dialog:

 Local package directory
 |
 +-> Mirror1 subdir
 |   |
 |   +-> x86
 |   |    |
 |   |    +-> setup.ini
 |   |
 |   +-> x86_64
 |        |
 |        +-> setup.ini
 |
 +-> Mirror2 subdir
 |   |
 |   +-> x86
 |   |   |
 |   |    +-> setup.ini
 |   |
 |   +-> x86_64
 |        |
 |        +-> setup.ini
 .
 .
 .

> > The patch is a bit big and mixes several things into one.  It would
> > be helpful for potential later blaming to split it into independent
> > chunks to commit separately.  E.g., in at least one instance you just
> > reordered a few lines without functional change.  This may better go
> > in as a separate style patch.
> 
> I'll see how to split it once I have thought about the search again.  It
> ended up that way since I didn't find an easy way to keep the separate
> parts both compiling and working, but since it's now in a more stable
> form I can revisit that question again.
> 
> > Otherwise it looks ok, but I'd be more comfortable to see the splitted
> > patches before ok'ing it.
> 
> No need for hurrying.  I'm on the opposite side of the planet for a
> week, so I'll take another look when I'm back.

Thanks a lot,
Corinna

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Maintainer                 cygwin AT cygwin DOT com
Red Hat
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://cygwin.com/pipermail/cygwin-apps/attachments/20150612/9463ce1f/attachment.sig>