[ITP] rpcbind 0.2.1
Yaakov Selkowitz
yselkowitz@cygwin.com
Thu Aug 21 02:04:00 GMT 2014
On 2014-08-20 13:22, Pavel Fedin wrote:
> Hello!
> I have completed rpcbind package and would like to offer it for the
> upload.
> https://www.dropbox.com/sh/ah2v9q1we8wl1oe/AACHiGJcCp6-oBrL2KEn7E7Wa?dl=0
> The same as onc-rpc-devel, this is x86-64-only for now.
Comments follow.
> OBSOLETES="sunrpc"
I'm wondering if onc-rpc-devel (which I'm starting to think should just
be called rpcgen) shouldn't obsolete sunrpc too instead of this. It's a
bit of a tough call because there is some overlap here.
> SRC_URI="http://sourceforge.net/projects/rpcbind/files/rpcbind/0.2.1/rpcbind-0.2.1.tar.bz2"
This should be:
SRC_URI="mirror://sourceforge/rpcbind/rpcbind-${VERSION}.tar.bz2"
> src_install () {
> cd ${B}
> cyginstall
> }
These are in /usr/sbin on Fedora, so in this particular case:
cyginstall bindir=/usr/sbin
> +#ifndef __CYGWIN__
> if (geteuid()) { /* This command allowed only to root */
Perhaps this is a candidate for using Daniel Boland's code?
> - syslog(LOG_ERR, "cannot get uid of '%s': %m", id);
> + syslog(LOG_ERR, "cannot get uid of '%s': %m", id);
This is just a whitespace difference, I suggest you leave it out of your
patch to ease future porting.
Yaakov
More information about the Cygwin-apps
mailing list