[PATCH setup 3/3] Add the last element of URL path to site chooser, if interesting.

[Corinna Vinschen]

On Apr 21 19:12, Jon TURNEY wrote:
> On 21/04/2014 15:10, Christopher Faylor wrote:
> > On Mon, Apr 21, 2014 at 12:16:27PM +0100, Jon TURNEY wrote:
> >> If I add the site http://mirrors.kernel.org/sources.redhat.com/cygwinports/ to
> >> setup's mirror list, using the GUI or --site option, I get two indistinguishable
> >> entries named http://mirrors.kernel.org in the mirror list box.
> >>
> >> So, to make the site chooser list entries more distinguishable, add the last
> >> element of the URL path to the site chooser, if it exists and isn't 'cygwin' (or
> >> some other alternatives used by current mirrors)
> >>
> >> As Corinna pointed out in Nov 2010, there is still a corner case of URLs which
> >> share protocol, hostname and the last element of the URL path being
> >> indistinguishable.  Additionally, it will need updating for any new mirrors which
> >> don't use one of the expected strings for the last path element in the URL.
> > 
> > I'd actually be ok with just displaying the whole URL even if it ends with Cygwin.
> > Is there a reason not to do that?
> 
> Last time this was discussed [1], I think you felt that the current site list
> and dialog box is too small to display the full URL usefully.
> 
> [1] http://cygwin.com/ml/cygwin-apps/2010-11/msg00134.html

The dialog has still a lot of space to the left and right of the URL
list window.  We could resize it to take the full available space even
in the smallest dialog size.  I think that would be sufficient most
of the time.  And the dialog can be resized if it doesn't suffice.


Corinna

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Maintainer                 cygwin AT cygwin DOT com
Red Hat
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://cygwin.com/pipermail/cygwin-apps/attachments/20140422/55d1e284/attachment.sig>