setup(-x86_64) bug - Download Incomplete possibly due to cdrkit

[Shaddy Baddah]

Hi,

When attempting to "Download Only" using setup-x86_64.exe, allowing the
default Pending selections of packages (ie. no manual selection at all)
I encountered a "Download Incomplete" yesno dialog box (see
http://imgur.com/lsoHFJE)

I believe there is a bug in the handling of the unusual entry for cdrkit
in setup.ini. Working backwards from the error message, I added the
debug lines as per the attached patch, rebuilt and ran fro mintty.
(Note, the patch also includes a change to the iterator variable name
from i -> j. Actually whilst not a bug, I think the fact that the inner
loop iterator hides the outer the iterator of the same name is bad
practise. Maybe someone could fix that up).

This snippet of output pointed to where the error is:

version e = 0, j = x86_64/release/bzip2/bzip2-1.0.6-2.tar.bz2
version e = 0, j base = bzip2-1.0.6-2
version e = 1, j =
version e = 1, j base =
version e = 0, j = x86_64/release/coreutils/coreutils-8.15-3.tar.bz2
version e = 0, j base = coreutils-8.15-3

Looking at the default pending packages (http://imgur.com/9osp4rK), 
cdrkit was conspicuous by both its absence and listing with no binary
package and only source.

This is backed up by the setup.ini extract:

# This file is automatically generated.  If you edit it, your
# edits will be discarded next time the file is generated.
# See http://cygwin.com/setup.html for details.
#
release: cygwin
arch: x86_64
setup-timestamp: 1376566401
setup-version: 2.819

...
@ cdrkit
category: Misc
version: 1.1.11-1
source: x86_64/release/cdrkit/cdrkit-1.1.11-1-src.tar.bz2 1462654 
4fe13fdfa36443f3a6acfcc6b6faf06e

I can help debug further if it helps. But I find setup's building of
various package sets daunting to look at on my own.

-- 
Regards,
Shaddy
-------------- next part --------------
A non-text attachment was scrubbed...
Name: DownloadIncomplete-debug.diff
Type: text/x-patch
Size: 1335 bytes
Desc: not available
URL: <http://cygwin.com/pipermail/cygwin-apps/attachments/20130816/46445cb7/attachment.bin>