ITP libunistring 0.9.3-1

[Yaakov (Cygwin/X)]

On Thu, 2011-10-06 at 22:52 +0200, Erwin Waterlander wrote:
> I propose package 'libunistring' for cygwin.

I presume you have another package in mind which will use this?

> http://waterlan.home.xs4all.nl/libunistring/libunistring-0.9.3-1.tar.bz2
> http://waterlan.home.xs4all.nl/libunistring/libunistring-0.9.3-1-src.tar.bz2

There are several packaging issues:

1) Libraries should be packaged in separate runtime and development
packages, so that nothing will break whenever the library ABI changes.

2) Your .cygport file uses internal functions.  This is not supported.

3) You have skipped the cygautoreconf step.  As mentioned in the cygport
documentation, this is strongly discouraged, particularly where libtool
is involved.

Therefore the .cygport should look like:

DESCRIPTION="Unicode string library"
HOMEPAGE="http://www.gnu.org/s/libunistring/"
SRC_URI="mirror://gnu/libunistring/${P}.tar.gz"

PKG_NAMES="libunistring0 libunistring-devel libunistring-doc"
libunistring0_CONTENTS="usr/bin/cygunistring-0.dll"
libunistring_devel_CONTENTS="usr/include/ usr/lib/"
libunistring_doc_CONTENTS="usr/share/doc/ usr/share/info/"

That's it.

4) I see this is one of Bruno's packages.  He has some unconventional
views about the PE format, and Cygwin in particular.  I would suggest
the attached patch.

> category: Libs
> requires: libgcc1
> sdesc: "Library for manipulating Unicode strings."
> ldesc: "This library provides functions for manipulating Unicode
> strings and for manipulating C strings according to the Unicode standard."

You will need separate .hint files for each subpackage, adding the
external-source tag.  You also need to add a libiconv2 dependency to the
runtime package and libiconv to the devel package.


Yaakov

-------------- next part --------------
A non-text attachment was scrubbed...
Name: libunistring-0.9.3-1.src.patch
Type: text/x-patch
Size: 1228 bytes
Desc: not available
URL: <http://cygwin.com/pipermail/cygwin-apps/attachments/20111007/c52ef781/attachment.bin>