[PATCH] Multiple --site options

[Jon TURNEY]

On 30/05/2011 10:28, szgyg wrote:
> I want to say `./setup.exe --site <ports> --site <local-repo>', so there it is.
>
> 2011-05-30 SZAVAI Gyula <szgyg-Vx2QyAHHJOs5Z0SDYBDJZg@public.gmane.org>
>
> * libgetopt++/src/StringArrayOption.cc: New file.
> * libgetopt++/include/getopt++/StringArrayOption.h: New file.
> * libgetopt++/Makefile.am: Add new files.
> * site.cc (SiteSetting::SiteSetting): Use them for multiple
> --site options.
> * crypto.cc (verify_ini_file_sig): Use them for multiple
> --pubkey and --sexpr-pubkey options.
> * package_meta.cc (packagemeta::isManuallyWanted): Use them for
> multiple --packages and --categories options.

I have no standing to approve or disapprove, but I like this patch, as at the 
moment I have to specify -X because I can't specify multiple -K options on the 
command line.

However, I think it needs a clearer description: What it actually does is
(i) add infrastructure for handling options which are repeated, and (ii) 
correctly handle multiple --site, --pubkey and -sexpr-pubkey options.

Would it make sense for the new StringArrayOption class derive from or have 
members of type StringOption, rather than duplicating some of it?