[patch/rebase] Open file only once
Corinna Vinschen
corinna-cygwin@cygwin.com
Sun Aug 7 07:51:00 GMT 2011
On Aug 6 18:54, Charles Wilson wrote:
> On 8/6/2011 3:25 PM, Corinna Vinschen wrote:
> > here's another simplification of peflags. The file gets opened and
> > closed in do_mark now. get_xxx and set_xxx get the pe_flags pointer
> > rather than the filename as parameter.
> >
> > Ok to apply?
>
> Sure, with minor changes: there are a couple of early returns where you
> need to call pe_close() first.
>
> line 281
> line 353
> line 361
Done in two steps. After I diligently changed the returns to gotos,
it occured to me that this is entirely useless since the set and get
functions now never fail anyway. So I dropped some more code from
do_mark in the second step.
Corinna
--
Corinna Vinschen Please, send mails regarding Cygwin to
Cygwin Project Co-Leader cygwin AT cygwin DOT com
Red Hat
More information about the Cygwin-apps
mailing list