[PATCH] inform user if any postinstall script failed to run

[Andy Koppe]

On 13 August 2010 12:29, Andy Koppe <andy.koppe@gmail.com> wrote:
> On 12 August 2010 20:42, Christopher Faylor  wrote:
>>>@@ -433,7 +433,9 @@
>>>     ICON            IDI_CYGWIN,IDC_HEADICON,SETUP_HEADICON_X,0,21,20
>>>     LTEXT           "Postinstall script errors",IDC_STATIC_HEADER_TITLE
>>>                     ,7,0,258,8,NOT WS_GROUP
>>>-    LTEXT           "The following errors occured executing
>>>postinstall scripts",
>>
>> I think you still need something like the above describing what is going
>> on.

Actually, isn't the bold "Postinstall script errors" heading just
above sufficient for that? Only two lines of text fit below it, ...

>>>+    LTEXT           "These don't necessarily mean that affected packages will "
>>>+                    "fail to function properly, but if you do notice problems "
>>>+                    "please check /var/log/setup.log.full.",
>>
>> Could this be put on the bottom?

... which I guess is why you suggested that? On second thoughts,
though, I think it does need to go above the errors because it's more
likely to be read there.

So here's another take at the patch, amended as suggested by Corinna.
It now also tweaks the bottom coordinate of the results text box,
because I found it ran into the line above the Back/Next/Cancel
buttons.

Index: postinstallresults.cc
===================================================================
RCS file: /cvs/cygwin-apps/setup/postinstallresults.cc,v
retrieving revision 1.1
diff -u -r1.1 postinstallresults.cc
--- postinstallresults.cc       29 Jul 2010 13:09:04 -0000      1.1
+++ postinstallresults.cc       14 Aug 2010 20:03:58 -0000
@@ -54,15 +54,6 @@
 long
 PostInstallResultsPage::OnNext ()
 {
-  // one or more postinstall scripts failed to run successfully
-  // installation may be broken
-  MessageBox (NULL,
-              "You will need to investigate and correct these errors "
-              "before your Cygwin installation will function properly.\n"
-              "Check setup.log for details.",
-              "ERROR - postinstall scripts failed",
-              MB_OK | MB_ICONERROR | MB_SETFOREGROUND | MB_TOPMOST);
-
   return IDD_DESKTOP;
 }

Index: res.rc
===================================================================
RCS file: /cvs/cygwin-apps/setup/res.rc,v
retrieving revision 2.88
diff -u -r2.88 res.rc
--- res.rc      6 Aug 2010 18:56:12 -0000       2.88
+++ res.rc      14 Aug 2010 20:03:59 -0000
@@ -433,9 +433,11 @@
     ICON            IDI_CYGWIN,IDC_HEADICON,SETUP_HEADICON_X,0,21,20
     LTEXT           "Postinstall script errors",IDC_STATIC_HEADER_TITLE
                     ,7,0,258,8,NOT WS_GROUP
-    LTEXT           "The following errors occured executing
postinstall scripts",
+    LTEXT           "These do not necessarily mean that affected packages "
+                    "will fail to function properly, but please check "
+                    "/var/log/setup.log.full and report any problems.",
                     IDC_STATIC,21,9,239,16,NOT WS_GROUP
-    EDITTEXT        IDC_POSTINSTALL_EDIT,7,41,303,124,WS_VSCROLL | WS_HSCROLL |
+    EDITTEXT        IDC_POSTINSTALL_EDIT,7,41,303,112,WS_VSCROLL | WS_HSCROLL |
                     ES_LEFT | ES_MULTILINE | ES_READONLY | ES_AUTOHSCROLL |
                     ES_AUTOVSCROLL