[PATCH] Incidental setup.exe patches #3: Simplify packagedb task handling

[Dave Korn]

On 14/04/2010 15:41, Dave Korn wrote:

>   I'll rewrite the comments now I know exactly what's going on and resend it
> later.

  Here:

	* root.cc (RootPage::OnNext): Don't construct a packagedb here nor
	do deferred initialisation of static packagedb::task.
	* source.cc (save_dialog): Don't construct a packagedb here, and
	set static packagedb::task directly instead of chosen_db_task.
	* package_meta.cc (packagemeta::action_caption): Don't bother to
	construct a packagedb here, just access packagedb::task directly.
	* package_db.cc: Move 'static members' comment near static members.
	(chosen_db_task): Delete.
	* package_db.h (chosen_db_task): Don't declare extern.
	(packagedb): Extend comments on class.

  OK now?

    cheers,
      DaveK
-------------- next part --------------
A non-text attachment was scrubbed...
Name: setup-simplify-packagedb-task-handling-take2.diff
Type: text/x-c
Size: 4464 bytes
Desc: not available
URL: <http://cygwin.com/pipermail/cygwin-apps/attachments/20100414/7a3c1842/attachment.bin>