Cygwin 1.7 setup-1.7.exe minor display error

Dave Korn dave.korn.cygwin@googlemail.com
Fri Jun 26 14:10:00 GMT 2009


Mark Harig wrote:

> 1. Start setup-1.7.exe.  Click on 'Next >' button until the
>    'Select Packages' dialog window is displayed.
> 
> 2. By default, setup displays the Select Packages window
>    maximized.  Click on the 'Restore Down' button in the
>    right-hand corner to reduce the size of the window.
> 
> 3. Note that to the right of the 'Search' box, the 'Clear' button
>    is not displayed (or, displayed only partially), as follows:
> 
>       Search |_________|[ o Keep  o Prev  o Curr o Exp [View] Category

  So, the attached patch both fixes the current layout of the chooser page
controls, and hopefully makes it a bit more easy to keep everything in line in
the future.

	* res.rc (SETUP_STANDARD_DIALOG_W, SETUP_STANDARD_DIALOG_H,
	SETUP_SMALL_DIALOG_W, SETUP_SMALL_DIALOG_H):  Add constant defines
	for dialog sizes.
	(SETUP_STANDARD_DIALOG_DIMS, SETUP_SMALL_DIALOG_DIMS):  Add helper
	macros for (W,H) pairs of dimensions.
	(SETUP_HEADICON_X):  New global constant define.
	(IDD_SOURCE, IDD_VIRUS, IDD_LOCAL, IDD_ROOT, IDD_SITE, IDD_NET,
	IDD_INSTATUS, IDD_PROXY_AUTH, IDD_NET_AUTH, IDD_DESKTOP,
	IDD_FTP_AUTH DIALOG, IDD_DROPPED):  Use the above for dialog sizes,
	horizontal rules and icon positioning.
	(SETUP_KPCE_W):  New define for radio-button size.
	(SETUP_VIEWCAP_W, SETUP_VIEWCAP_X, SETUP_VIEW_W, SETUP_VIEW_X,
	SETUP_EXP_X, SETUP_CURR_X, SETUP_PREV_X, SETUP_KEEP_X):  Add defines
	for right-aligned controls.
	(SETUP_SEARCH_X, SETUP_SEARCH_W, SETUP_SEARCHTEXT_X,
	SETUP_SEARCHTEXT_W, SETUP_CLEAR_X, SETUP_CLEAR_W):  Likewise defines
	for left-aligned controls.
	(IDD_CHOOSE):  Use all the above, and reformat with whitespace
	between args for clarity.

  Tested by visual inspection of the chooser page while playing with the
maximize/restore controls and free resizing.  Ok?

    cheers,
      DaveK

-------------- next part --------------
A non-text attachment was scrubbed...
Name: setup-resize-fixes.diff
Type: text/x-c
Size: 16582 bytes
Desc: not available
URL: <http://cygwin.com/pipermail/cygwin-apps/attachments/20090626/eb358a40/attachment.bin>


More information about the Cygwin-apps mailing list