[PATCH] setup: Always draw chooser icons using system colors

[Brian Dessent]

Igor Peshansky wrote:

> As promised in <http://cygwin.com/ml/cygwin/2006-05/msg00612.html>, here's
> a patch that makes setup always draw the chooser icons using the system
> foreground and background colors (just like it does for text).  I've also
> taken the opportunity to do a slight bit of code clean-up.  There's still
> a little glitch left -- when doing a lot of fast scrolling back and forth,
> the icons sometimes switch from the system foreground color to the
> inverted system background color.  I think I know why this is happening
> (i.e., the FillRgn() gets ignored for some reason), but this needs further
> debugging.  As this is a corner case, I wouldn't worry too much about it.
> As always, the ChangeLog is below -- opinions welcome.

Thanks for taking a look at this.  I like that it abstracts all the
blitting to one place, although it seems wasteful to me to have to
create and destroy dc_tmp like that every time.  However, whatever
performance hit this creates is probably better than the blatant
incorrectness that is there now, so I guess this is progress.  I'm also
a little hesitant about this glitch you mention, but it sounds like
you're on top of that too so I say go ahead and check this in and we can
smooth out the rough edges later.

Brian