[PATCH] setup: replace radiobuttons on chooser

[Dave Korn]

  Hi all, here's my contribution to the current setup patchfrenzy!

  The radiobuttons for Prev, Keep, Curr, Exp at the top of the package chooser
should never have been radiobuttons.  They don't select a persistent mode,
they perform an instantaneous action.  Action buttons should be pushbuttons.
Hence this patch changes them to pushbuttons.

  Also, the view button with the cycling every time you click it thing?  Eww!
:-P

  So I made it a combo box.  Now you can switch straight from one view to
another without stepping through the ones you didn't want to see first.  I
think that's more windows-UI-y-ish, IYSWIM.

  ChangeLog:

2006-03-12  Dave Korn  <dave.korn@artimi.com>

	* resource.h (IDC_CHOOSE_VIEWCAPTION):  Deleted, replaced by ...
	(IDC_CHOOSE_VIEW_LABEL):  New static text control.
	(IDC_SELECTION_LABEL):  New static text control.
	(IDS_VIEWMODE_CATEGORY, IDS_VIEWMODE_FULL, IDS_VIEWMODE_PARTIAL,
	IDS_VIEWMODE_UP_TO_DATE, IDS_VIEWMODE_NO_INSTALLED):  New strings.
	* res.rc (IDC_CHOOSE_KEEP):  Changed from radio to pushbutton and
	realigned to top left.
	(IDC_CHOOSE_PREV, IDC_CHOOSE_CURR, IDC_CHOOSE_EXP):  Likewise and
	aligned abutting.
	(IDC_SELECTION_LABEL):  Add label for pushbuttons.
	(IDC_CHOOSE_VIEW_LABEL):  Add label for view mode combobox.
	(IDC_CHOOSE_VIEW):  Changed to combobox and right aligned.
	(IDC_CHOOSE_VIEWCAPTION):  Deleted.
	(IDS_VIEWMODE_CATEGORY, IDS_VIEWMODE_FULL, IDS_VIEWMODE_PARTIAL,
	IDS_VIEWMODE_UP_TO_DATE, IDS_VIEWMODE_NO_INSTALLED):  New strings
	to describe chooser view modes.
	* choose.h (ChooserPage::combobox):  New HWND member.
	* choose.cc (ChooserControlsInfo):  Realign changed items.
	(VIEWMODE_NAME_MAX):  Arbitrary maximum length for text strings
	describing view modes.
	(ChooserViewModes):  Array relating PickView views constants to
	string table entries naming them.
	(NumChooserViewModes):  Number of entries in the table.
	(ChooserPage::createListview):  Don't use radiobutton grouping or
	alter static text on view mode.  Reset combobox and add entries from
	ChooserViewModes[] array instead.
	(ChooserPage::OnMessageCmd):  Handle selection from combobox, and
	don't check tick state of radio buttons as they are now pushbuttons.



    cheers,
      DaveK
-- 
Can't think of a witty .sigline today....
-------------- next part --------------
A non-text attachment was scrubbed...
Name: chooser-buttons.patch
Type: application/octet-stream
Size: 8997 bytes
Desc: not available
URL: <http://cygwin.com/pipermail/cygwin-apps/attachments/20060312/fccc5575/attachment.obj>