updated: guile-1.6.7-2, guile-1.7.2-2

[Eric Blake]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

According to Jan Nieuwenhuizen on 10/1/2005 12:24 AM:
> I've repackaged the guile packages fixing two bugs in libtool .la
> files: Incorrect cyg prefixes on .a and .dll.a files and cross build
> artifacts.
> 
> Please upload.

Sorry to be picky, but I noticed several nits in the packaging.

> 
> Jan.
> 
> 
> http://lilypond.org/cygwin/uploads/guile/setup.hint
> http://lilypond.org/cygwin/uploads/guile/guile-1.6.7-2-src.tar.bz2
> http://lilypond.org/cygwin/uploads/guile/guile-1.6.7-2.tar.bz2

Your setup.hint mentions that depending on readline is useful although not
a direct dependence, but then list libncurses7 and libreadline5 instead of
the current libncurses8 and libreadline6.  On the other hand, since they
are not direct dependencies here, but libreadline6 IS a direct dependency
of libguile12, you should probably only list libreadline6 in the
libguile12 setup.hint, rather than here.

Your binary package includes usr/share/doc/Cygwin/changelog.Cygwin, which
is inappropriate for the Cygwin directory (that file, if distributed,
should be in usr/share/doc/guile-1.6.7/).  Also, it should be
usr/share/doc/guile-1.6.7/, not usr/share/doc/guile-1.6.7-2/.

> 
> ===
> 
> http://lilypond.org/cygwin/uploads/guile/setup.hint
> http://lilypond.org/cygwin/uploads/guile/guile-1.7.2-2-src.tar.bz2
> http://lilypond.org/cygwin/uploads/guile/guile-1.7.2-2.tar.bz2

The source package includes generated files, such as autom4te.cache/, that
add quite a bit of useless bulk.  Have you considered using the
generic-build-script?

> 
> ===
> 
> http://lilypond.org/cygwin/uploads/guile/guile-devel/setup.hint
> http://lilypond.org/cygwin/uploads/guile/guile-devel/guile-devel-1.6.7-2.tar.bz2

Since guile-snarf and guile-tools are shell scripts, this setup.hint
should also depend on bash (although this isn't critical, since bash is in
the BASE package).

> 
> ===
> 
> http://lilypond.org/cygwin/uploads/guile/guile-devel/setup.hint
> http://lilypond.org/cygwin/uploads/guile/guile-devel/guile-devel-1.7.2-2.tar.bz2
> 
> ===
> 
> http://lilypond.org/cygwin/uploads/guile/guile-doc/setup.hint
> http://lilypond.org/cygwin/uploads/guile/guile-doc/guile-doc-1.6.7-2.tar.bz2

You may want to consider compressing the info files (most packages use
gzip because of the current state of g-b-s, although bzip2 is probably okay).

> 
> ===
> 
> http://lilypond.org/cygwin/uploads/guile/guile-doc/setup.hint
> http://lilypond.org/cygwin/uploads/guile/guile-doc/guile-doc-1.7.2-2.tar.bz2
> 
> ===
> 
> http://lilypond.org/cygwin/uploads/guile/libguile12/setup.hint
> http://lilypond.org/cygwin/uploads/guile/libguile12/libguile12-1.6.7-2.tar.bz2

The setup.hint is missing several dependencies: crypt and readline6

> 
> ===
> 
> http://lilypond.org/cygwin/uploads/guile/libguile16/setup.hint
> http://lilypond.org/cygwin/uploads/guile/libguile16/libguile16-1.7.2-2.tar.bz2

Here, the setup.hint is missing crypt and libint3.  I'm not sure whether
.la files belong in usr/bin, or whether they should always be in usr/lib,
but that may just be my misunderstanding of libtool.

- --
Life is short - so eat dessert first!

Eric Blake             ebb9@byu.net
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (Cygwin)
Comment: Public key at home.comcast.net/~ericblake/eblake.gpg
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org

iD8DBQFDPxPj84KuGfSFAYARAldWAJ479SPswLzHXiEWD1uNms0C/N3efACeIJhS
neiwJwOCwWz4eMRy4GA75F0=
=q25N
-----END PGP SIGNATURE-----