[patch] manifest, and test release

[Max Bowsher]

Brian Dessent wrote:
>> So, I see that you have taken care of the markVisited() bug.

Almost. One more commit coming up to finish that one off.
Everything I've committed so far has been things that I encountered whilst 
reviewing, rather than your change itself.

>>  There's
>> that one, the proxy port one, and the "d.sh" postinstall one, all of
>> which still exist in the wild in current setup.exe no?

Yes, that is correct.

>> I'm posting the patch for the manifest.  If there are no objections I'd
>> like to commit this and see about rolling a test release soon.  How does
>> that sound Max?

There is one remaining issue - here is a ChangeLog entry from the current 
release branch:

2004-11-28  Max Bowsher  <maxb@ukf.net>

        * download.cc (check_for_cached): Re-introduce the silent skipping 
of
        wrong-sized package files in local caches, as a "quick fix" that is 
no
        worse than the status quo, to be able to make a release, whilst work
        towards a proper fix continues on trunk.

It's getting late here - let me reexamine it in the morning, and I'll 
summarize the situation in a bit more detail.

>> 2005-05-03  Brian Dessent  <brian@dessent.net>
>>
>> * res.rc: (CREATEPROCESS_MANIFEST_RESOURCE_ID): Define so that
>> manifest is included in the binary.  This causes the common
>> controls to appear more modern on recent versions of Windows.
>> * setup.exe.manifest: New file.

Good! With one minor comment below...

>> Index: res.rc
>> ===================================================================
>> RCS file: /cvs/cygwin-apps/setup/res.rc,v
>> retrieving revision 2.58
>> diff -u -r2.58 res.rc
>> --- res.rc 20 Nov 2004 17:25:29 -0000 2.58
>> +++ res.rc 3 May 2005 22:51:40 -0000
>> @@ -497,6 +497,8 @@
>>     IDS_UNCAUGHT_EXCEPTION_WITH_ERRNO  "Fatal Error: Uncaught
>> Exception\nThread: %s\nType: %s\nMessage: %s\nAppErrNo: %d" END
>>
>> +CREATEPROCESS_MANIFEST_RESOURCE_ID RT_MANIFEST "setup.exe.manifest"
>> +
>> #endif    // English (U.S.) resources
>> /////////////////////////////////////////////////////////////////////////////
>>
>> --- /dev/null 2005-05-03 15:56:41.072375000 -0700
>> +++ setup.exe.manifest 2005-05-03 15:23:04.619250000 -0700
>> @@ -0,0 +1,22 @@
>> +<?xml version="1.0" encoding="UTF-8" standalone="yes"?>
>> +<assembly xmlns="urn:schemas-microsoft-com:asm.v1" 
>> manifestVersion="1.0">
>> +<assemblyIdentity
>> +    version="1.0.0.0"
>> +    processorArchitecture="X86"
>> +    name="RedHat.Cygwin.Setup"

... perhaps just "Cygwin.Setup" here ?


Max.