for generic-build-script

[Gerrit P. Haase]

Hallo Yaakov,

Am Mittwoch, 19. Mai 2004 um 19:34 schriebst du:

> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1

> Gerrit P. Haase wrote:
> | Hallo cygwin-apps,
> |
> | --- generic-build-script~       2004-05-19 15:49:55.827961600 +0200
> | +++ generic-build-script        2004-05-19 15:49:41.196923200 +0200
> | @@ -180,7 +180,7 @@
> |      fi ;\
> |    done &&\
> |    if [ -d ${instdir}${prefix}/share/info ] ; then \
> | -    find ${instdir}${prefix}/share/info -name "*.info" | xargs gzip
> - -q ; \
> | +    find ${instdir}${prefix}/share/info -name "*" | xargs gzip -q ; \
> |    fi && \
> |    if [ -d ${instdir}${prefix}/share/man ] ; then \
> |      find ${instdir}${prefix}/share/man -name "*.1" -o -name "*.3" -o \
> |
> | # END OF ANNOUNCEMENT

> Gerrit,

> Could you explain your reasoning behind this patch?  Since I contributed
> this part of the g-b-s, let me explain this.  Basically, I wanted to
> make sure that we were gzipping just the man and info pages, not
> subdirs,

add `-type f`


> and not pages that were already compressed (I've built a couple
> of programs that would gzip the man pages themselves on install).

gzip takes care of it.

> But I see now with the info pages that it's more complicated than *.info
> in the cases when there are multiple info page files for one program,
> such as gcc, gdb, make, emacs, etc.  Is that what your intention is?

Exact. The "*.info" does not match on "*.info-1".


> If so, let me propose the attached patch instead.  These changes should
> make sure that:
> 1) all pages are being compressed, no matter how they are named;
> 2) only files are being compressed;
> 3) pages already compressed won't be compressed again;
> 4) if no qualifying pages are found, gzip won't complain (xargs -r).

Yes, looks better (not tested yet), but why not go the easy way?  Look
what I do for GCC:

   ( cd ${PKG1}${prefix}/share/info ; rm -f dir ; gzip -fq9 * ) && \
   ( cd ${PKG1}${prefix}/share/man && gzip -fq9 */* ) && \

As said above, files already compressed will not be touched by gzip.

Gerrit
-- 
=^..^=