[PATCH] for generic-build-script

[Igor Pechtchanski]

On Wed, 19 May 2004, Christopher Faylor wrote:

> On Wed, May 19, 2004 at 03:52:04PM +0200, Gerrit P. Haase wrote:
> >Hallo cygwin-apps,
> >
> >--- generic-build-script~       2004-05-19 15:49:55.827961600 +0200
> >+++ generic-build-script        2004-05-19 15:49:41.196923200 +0200
> >@@ -180,7 +180,7 @@
> >     fi ;\
> >   done &&\
> >   if [ -d ${instdir}${prefix}/share/info ] ; then \
> >-    find ${instdir}${prefix}/share/info -name "*.info" | xargs gzip -q ; \
> >+    find ${instdir}${prefix}/share/info -name "*" | xargs gzip -q ; \
>
> -name "*" is a no-op.  You can just remove it.

Yep.  I think what was intended here was "-type f".

> Also, shouldn't all of these directories be quoted, i.e:
>
> find "${instdir}${prefix}/share/info" -print0 | xargs -0 gzip -q
>
> cgf

True, but, AFAICS, the whole GBS suffers from this.  I should make a pass
and fix all of them in one sweep.

Gerrit, how about a resubmit, with or without the quoting, but with a
ChangeLog?
	Igor
-- 
				http://cs.nyu.edu/~pechtcha/
      |\      _,,,---,,_		pechtcha@cs.nyu.edu
ZZZzz /,`.-'`'    -.  ;-;;,_		igor@watson.ibm.com
     |,4-  ) )-,_. ,\ (  `'-'		Igor Pechtchanski, Ph.D.
    '---''(_/--'  `-'\_) fL	a.k.a JaguaR-R-R-r-r-r-.-.-.  Meow!

"I have since come to realize that being between your mentor and his route
to the bathroom is a major career booster."  -- Patrick Naughton