[Review - Almost GTG] TeXmacs: A scientific wysiwyg Editor and Interface for Computer Algebra Systems

[Dr. Volker Zell]

>>>>> "Andreas" == Andreas Seidl writes:

    Andreas> Volker,

    Andreas> first of all many thanks for this in-depth review and for pointing out
    Andreas> the sore spots.

okidoki

    Andreas> $ cygcheck -svr | grep gcc
    Andreas> Found: C:\cygwin\bin\gcc.exe
    Andreas> gcc                     3.3.1-3
    Andreas> gcc-mingw-core          20031020-1

As Igor already pointed out you haven't installed g++.
Try installing it and make a new release. I'll review that version.

    >> One last thing I noticed. Your version depends on cygiconv-2.dll but
    >> when I configure from source iconv support doesn't get included:
    >> checking for iconv.h... yes checking for iconv... no checking for
    >> iconv in -liconv... no configure: warning: iconv was not found, HTML
    >> import may crash
    >> excerpt from config.log:
    >> configure:2535: checking for iconv in -liconv configure:2552: gcc -o
    >> conftest -O2   conftest.c -liconv 1>&5
    >> /tmp/cc0X42Ma.o(.text+0x35):conftest.c: undefined reference to
    >> `_iconv_open' /tmp/cc0X42Ma.o(.text+0x5d):conftest.c: undefined
    >> reference to `_iconv' collect2: ld returned 1 exit status configure:
    >> failed program was: #line 2539 "configure" #include "confdefs.h"
    >> #include <stdlib.h> #include <iconv.h>
    >> int main() {
    >> iconv_t cd = iconv_open ("",""); iconv (cd, NULL, NULL, NULL, NULL);
    >> ; return 0; }
    >> Grepping for iconv_open symbol
    >> 02:53 PM [534]> nm /usr/lib/libiconv.dll.a | grep iconv_open 00000000
    >> I __imp__libiconv_open 00000000 T _libiconv_open
    >> shows that configure *SHOULDN'T* find iconv support.

    Andreas> I can confirm this data, the conclusion, however, is not clear to me.
    Andreas> Does this mean there is a portability issue and the configure script
    Andreas> should be changed from iconv_open to libiconv_open?

I'm not sure, but my question is how your version includes iconv support
as you can see from the cygcheck output. Doesn' t your configure step
fails with the same error messages as mine ?


    >> -  xfree68-base -  xfree68-prog +  XFree68-base +  XFree68-prog

    Andreas> There is an additional typo: 68 instead of 86! This means X
    Andreas> got

OOPS. Because I hand edited it and just uppercased your old version.


    Andreas> installed due to a dependency from ghostscript-x11 ... argh! Which means
    Andreas> that maybe XFree86-prog is not necessary.

Yap, XFree86-prog is not a runtime requirement.

    Andreas> find $tmp/$PKG-$VER/.inst -name '*.exe' | xargs cygcheck | sed -e
    Andreas> '/\.exe/d' -e 's,\\,/,g' | sort -bu | xargs -n1 cygpath -u | xargs
    Andreas> cygcheck -f

    Andreas> but this doesn't work anymore (and only worked for ccrypt, not for texmacs).

Try the following the texmacs executable has a bin extension:

find  $tmp/$PKG-$VER/.inst -name '*.exe' -o -name '*.dll' \
   -o -name '*.bin' | \xargs cygcheck | \
   sed -e '/\.exe/d' -e 's,\\,/,g' | sort -bu | \
   xargs -n1 cygpath -u | xargs cygcheck -f | uniq

    Andreas> Ciao,
    Andreas> Andreas.

Ciao
  Volker