[PATCH] Allow logging of {pre,post}remove scripts
Igor Pechtchanski
pechtcha@cs.nyu.edu
Mon Mar 31 23:31:00 GMT 2003
On 1 Apr 2003, Robert Collins wrote:
> On Tue, 2003-04-01 at 08:02, Igor Pechtchanski wrote:
> > On 1 Apr 2003, Robert Collins wrote:
> >
> > > Uhmm, try_run_script is always called with to_log true. So, why have the
> > > parameter there at all?
> > > Rob
> >
> > Umm, for symmetry? If you ever wanted to turn off logging, all you'd have
> > to do is change the calls. By the same coin, run_script is never called
> > without logging either... If the decision were made to *always* do the
> > logging, both parameters should be eliminated at the same time.
> > Igor
>
> Well, before when you where making changes to run_script, we where
> migrating. Now, AFAICT all callers will use true, hard coded into the
> source, to cause logging.
>
> Thus, I'm suggesting that rather than propagate the to_log parameter
> around, we simply making logging occur always.
>
> If we decide we want different log targets (i.e. file, console,
> /dev/null) then we won't have any obsolete code to cleanup at that
> point.
>
> Rob
Rob,
The reason I wanted to keep the to_log parameter is that I wanted to keep
the code around that directs output to console. If there are no
objections, I'll just make the default value of to_log TRUE, and remove
the third parameter from the calls. I'd like to keep the parameter for
now, though.
Igor
--
http://cs.nyu.edu/~pechtcha/
|\ _,,,---,,_ pechtcha@cs.nyu.edu
ZZZzz /,`.-'`' -. ;-;;,_ igor@watson.ibm.com
|,4- ) )-,_. ,\ ( `'-' Igor Pechtchanski
'---''(_/--' `-'\_) fL a.k.a JaguaR-R-R-r-r-r-.-.-. Meow!
Knowledge is an unending adventure at the edge of uncertainty.
-- Leto II
More information about the Cygwin-apps
mailing list