[PATCH] Re: proxy setup help

[Robert Collins]

On Sat, 2003-03-08 at 07:50, Max Bowsher wrote:


> > Should do it.
> 
> Except it doesn't work - the OK button is still disabled.

Ah:[.

> Would you like me to also remove the check on *passwd here:
> static void
> check_if_enable_ok (HWND h)
> {
>   int e = 0;
>   if (*user && *passwd)

Well, that should work untouched - my patch was intended to change
(*password) from NULL on empty dialog box to a pointer to char[1]. My
patch must have been faulty then...

>     e = 1;
>   EnableWindow (GetDlgItem (h, IDOK), e);
> }
> 
> or, would you prefer my invasive-but-less-kludgy patch.

It's more kludgy. You're changing the behaviour of a low level tool in a
way that produces scattered changes, rather than isolating the needed
changes and addressing those.

Rob
.
-- 
GPG key available at: <http://users.bigpond.net.au/robertc/keys.txt>.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
URL: <http://cygwin.com/pipermail/cygwin-apps/attachments/20030307/9c057fc8/attachment.sig>