[SetupXP] PropertyPage::OnInit

Robert Collins rbcollins@cygwin.com
Sat Jul 19 13:57:00 GMT 2003


On Sat, 2003-07-19 at 23:33, Max Bowsher wrote:
> I would like to propose NOT moving the global font settings into
> PropertyPage::OnInit, and consequently not requiring "Call base class
> OnInit()" changes in all derived classes.
> 
> Since the font settings are *already* set up to fail silently if the
> relevant control is not present, I don't think we need or should give
> derived classes the ability to override this, especially when it adds an
> extra burden, which could be accidentally omitted when a new page was
> created.

Max, I appreciate the reviews you are doing. May I suggest that
submitting the various component patches that make up Gary's work is the
best way to review each aspect of it...

Rob
-- 
GPG key available at: <http://members.aardvark.net.au/lifeless/keys.txt>.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
URL: <http://cygwin.com/pipermail/cygwin-apps/attachments/20030719/dacd077a/attachment.sig>


More information about the Cygwin-apps mailing list