[PATCH] Re: [setup] Inaccurate message: See /setup.log.full

[Robert Collins]

On Sun, 2003-02-02 at 08:44, Max Bowsher wrote:


> > No it's not, because the current setup code *always* uses a log file
> > of the appropriate level. It's a fallback to catch future changes.
> 
> Well, at least make it "<no log was in use>" (with the brackets) to make the
> message easier to read.

Fine by me.

> >> How about:
> >
> > No. I like Igors approach better.
> > For yours, we end up with duplicate resources : you should split the
> > 'installation incomplete' and the log to check into two separate
> > messages.
> 
> Then you have to tangle with temporary buffers to combine them.

That should be trivial with the string classes, and if it's not, then
that sounds like a call for a method or operator on cistring.

> > Lastly we should be looking at how we pull conditionals out of
> > LogFile,
> > not inserting them.
> 
> I can't see how else to acheive the result I intended without major
> restructuring.

So, take steps toward the overall result, not away from it.

Rob

-- 
GPG key available at: <http://users.bigpond.net.au/robertc/keys.txt>.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
URL: <http://cygwin.com/pipermail/cygwin-apps/attachments/20030201/33e656ca/attachment.sig>