Astyle review

Lapo Luchini lapo@lapo.it
Wed Sep 11 08:53:00 GMT 2002


I can see only minor ploblems:
- setup.hint: I always seen people suggest to put new packages that can 
do no real damane directly in current, and not test branch. but again 
this could be better this way.
- binary package:
  - docs are installed in /usr/doc/astyle_1.15.3/ instead of the more 
usual /usr/doc/astyle-1.15.3/, ditto for the 
usr/doc/Cygwin/astyle_1.15.3..README file. this is a very *little* bug, 
I guess we can live with it (I'll mark it a "non-stopping 
marked-for-the-next-release bug")
  - executable works (no big testing done)
- source package
  - it extracts in the directory astyle_1.15.3, instead of astyle-1.15.3
  - patch: last line contains an unuseful "Binary files .. and ... differ"
  - patch: compares files in /home/rsato/software/astyle/astyle_1.15.3/ 
with files in astyle_1.15.3/ (patch asks for file to change)
  - README: doesn't say how to remove patch from archive and if it is 
already applied (it seems to be already applied, BTW)

Keep in my that this is my first "complete review", be gente 0=)

-- 
Lapo 'Raist' Luchini
lapo@lapo.it (PGP & X.509 keys available)
http://www.lapo.it (ICQ UIN: 529796)




More information about the Cygwin-apps mailing list