rebasing new packages?!

Jason Tishler jason@tishler.net
Mon May 6 07:50:00 GMT 2002


Rob,

On Sat, May 04, 2002 at 09:37:48AM +1000, Robert Collins wrote:
> > -----Original Message-----
> > From: Jason Tishler [mailto:jason@tishler.net] 
> > Sent: Saturday, May 04, 2002 3:34 AM
> > 
> > Can we remove the "-Werror" option and start using STL in setup.exe?
> 
> [snip]
>
> Perhaps removing the explicit inline from the definition is appropriate?

Bingo.  That fixed the problem.  Sorry, for being sloppy.

Should I send the attached patch to the Cygwin gcc maintainer?

> (-O3 will automatically inline it, and probably get that warning again,
> but casual users would be safe.

I tried the "-O3" option and the warning did *not* occur.

If the attached patch is accepted, can I start using STL in setup.exe
now?

Thanks,
Jason
-------------- next part --------------
--- stl_tree.h.orig	Mon May  6 10:38:33 2002
+++ stl_tree.h	Mon May  6 10:38:52 2002
@@ -1253,7 +1253,7 @@ _Rb_tree<_Key, _Value, _KoV, _Compare, _
                                              upper_bound(__k));
 }
 
-inline int 
+int 
 __black_count(_Rb_tree_node_base* __node, _Rb_tree_node_base* __root)
 {
   if (__node == 0)


More information about the Cygwin-apps mailing list