binutils/binutils: 2.23.2 is a 2_23_or_later (ie. has gold)
Fri Jan 3 10:00:00 GMT 2014
Happy new year.
I've resubmitted both "patches" I submitted earlier, but now (hopefully)
in the proper format.
On 01/02/2014 09:55 PM, Yann E. MORIN wrote:
> Niels, All,
> Happy New Year to all!
> On 2014-01-02 10:37 +0100, Niels Penneman spake thusly:
>> You have added the BINUTILS_2_24_or_later symbol in Kconfig but
>> unfortunately BINUTILS_V_2_24 does not select it. You also did not mark
>> it as experimental; perhaps the latter was intended.
> Doh, it seems that comitting stuff on New Year's Eve was a bad idea to
> begin with! :-/
> Thanks for spotting this! :-)
>> Here's a "suggestion":
> Thanks for the "suggestion"!
> But, could you please send a 'proper' patch, with subject, commit log
> and your Signed-off-by line, like, for example:
> You can use 'hg email' to send your patches. See:
> docs/7 - Contributing to crosstool-NG.txt
> and section titled 'Using Mercurial to hack crosstool-NG' in:
> docs/C - Misc. tutorials.txt
> Yann E. MORIN.
> PS. I did not see that you did provide the binutils 2.23.2 patch, hence
> the reason I did not credit you as being the author. Apologies... :-(
> Also, that patch was not properly prepared (see above).
>> diff --git a/config/binutils/binutils.in b/config/binutils/binutils.in
>> index 64ce389..e007e3c 100644
>> --- a/config/binutils/binutils.in
>> +++ b/config/binutils/binutils.in
>> @@ -10,7 +10,9 @@ choice
>> config BINUTILS_V_2_24
>> - prompt "2.24"
>> + prompt "2.24 (EXPERIMENTAL)"
>> + depends on EXPERIMENTAL
>> + select BINUTILS_2_24_or_later
>> config BINUTILS_V_2_23_2
>> On 12/31/2013 12:46 PM, Yann E. MORIN wrote:
>>> Yann, All,
>>> Your patch:
>>> binutils/binutils: 2.23.2 is a 2_23_or_later (ie. has gold)
>>> has been applied as: #7b7d953f9cfb
>>> Thank you!
>>> Yann E. MORIN.
> PPS: In case someone wondered: this was an automatic mail, I'm not
> narcissistic enough to send myself a congratulation mail! ;-)
> That kind of mail is sent as soon as I'm not the author, or someone else
> than me signed-off (or reported, or acked or added any other sob-line)
> on the patch.
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 901 bytes
Desc: OpenPGP digital signature
More information about the crossgcc