[PATCH] scripts: Make the crosstool-NG version an optional part of pkgversion

[Michael Hope]

On Wed, Oct 19, 2011 at 5:20 AM, Yann E. MORIN
<yann.morin.1998@anciens.enib.fr> wrote:
> Michael, All,
>
> On Monday 17 October 2011 05:39:47 Michael Hope wrote:
>> # HG changeset patch
>> # User Michael Hope <michael.hope@linaro.org>
>> # Date 1317709748 -46800
>> # Node ID 931a96c7b84610c33a5535f574adf01df63d1a89
>> # Parent  5b157f46a3ab4830e4117811e9338e7d74d3a55d
>> scripts: Make the crosstool-NG version an optional part of pkgversion.
>
> If I may ask, what is the reason you (Linaro) would not want to identify
> crosstool-NG in the pkgversion string?

Just brevity. We set the Linaro release as the default package
version, so for source builds you get a string like:
 gcc (Linaro GCC 4.6-2011.09) 4.6.2 20110908 (prerelease)

For binary builds I was planning on using a pkgversion like 'Linaro
GCC 4.6-2011.09+bin1' to show the particular build script release used
to make the binary.  We need to identify the build scripts to fully
meet the terms of the GPL.

> Would it be better if the crosstool-NG ID string was placed _after_ the
> custom string?

Yeah, that would be fine.

>> We use the pkgversion for the Linaro release name.  This patch lets you
>> turn off the automatic crosstool-NG@revno and just use the configured
>> package version.
>
> Note that, for release, the 'revno' is replaced by the version string,
> so it is much shorter; that is, something like:
>    crosstool-NG 1.12.4
>
>> +config TOOLCHAIN_PKGVERSION_WITH_CROSSTOOL
>> +    bool
>> +    prompt "Include the crosstool-NG version in the ID string"
>> +    default y
>> +    help
>> +      Include the crosstool-NG version in the package version string.
>
> If this was to make it in, I would add:
>    depends on TOOLCHAIN_PKGVERSION != ""
>
> So there's at least one pkgversion string:
>  - the crosstool-NG ID string
>  - the crosstool-NG + the custom ID strings
>  - the custom ID string
>
> OK for you?

I'd like to withdraw the patch for now and think about it some more.
Linaro work upstream, but no matter what we'll end up with a branch
for patches that aren't upstreamable.  Therefore a name like 'Linaro
GCC yyyy.mm + crosstool-NG r12345' isn't true as it's not crosstool-NG
r12345, but r12345 of our branch.

-- Michael

--
For unsubscribe information see http://sourceware.org/lists.html#faq