[PATCH 1 of 6] config/target: add float support selection
Yann E. MORIN
yann.morin.1998@anciens.enib.fr
Mon Nov 28 17:46:00 GMT 2011
Thomas, All,
On Monday 28 November 2011 13:32:21 Thomas Petazzoni wrote:
> Le Sat, 26 Nov 2011 00:22:26 +0100,
> "Yann E. MORIN" <yann.morin.1998@anciens.enib.fr> a écrit :
>
> > +config ARCH_SUPPORT_FLOAT
> > + bool
> > +
>
> The option name sounds a bit misleading to me. Reading this code, I
> would assume that the option means "does the architecture supports
> floating point computation ?", which of course is not what is happening
> here.
Indeed, this is misleading. But I named the option as par with the others
around it:
ARCH_SUPPORT_CPU --> supports --with-cpu= and -mcpu=
ARCH_SUPPORT_TUNE --> supports --with-tune= and -mtune=
ARCH_SUPPORT_FLOAT --> supports --with-float= and -mfloat=
ARCH_SUPPORT_FPU --> supports --with-fpu= and -mfpu=
Of course, this does not match for the following option:
ARCH_SUPPORT_SOFTFP
Also, the options are not consistenly named:
ARCH_SUPPORT_CPU but ARCH_SUPPORTS_64
This could probably be improved, indeed... I'll see if I can get sometime
for it soonish...
Thanks for the review!
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
--
For unsubscribe information see http://sourceware.org/lists.html#faq
More information about the crossgcc
mailing list