[CT-NG 1.11.1] Error if libidn added to (e)glibc add-ons to build

[Benoît THÉBAUDEAU]

Hi all,

With CT-NG 1.11.1, I get the following error if libidn is added to the eglibc
2.13 add-ons to build:

[ERROR]    'eglibc-libidn-2_13' not found in '/tools/.build/tarballs'

This error is caused by do_libc_extract(), which does not handle libidn like
nptl, although it should since both are built-in eglibc add-ons (at least for
eglibc 2.13), so no tarball has to be downloaded/extracted for them.

The same seems to be true for the glibc.

A workaround could be remove libidn from CT_LIBC_ADDONS_LIST and to add
--enable-add-ons=nptl,ports,libidn to CT_LIBC_GLIBC_EXTRA_CONFIG in
menuconfig, but that would only be an ugly workaround.

One could do:
---
-        # NPTL addon is not to be extracted, in any case
-        [ "${addon}" = "nptl" ] && continue || true
+        # LIBIDN and NPTL addons are not to be extracted, in any case
+        [ "${addon}" = "libidn" -o "${addon}" = "nptl" ] && continue || true
---
But this issue might not apply to all versions of (e)glibc, so that would be
wrong.

Or:
---
-        # NPTL addon is not to be extracted, in any case
-        [ "${addon}" = "nptl" ] && continue || true
+        # Built-in addons are not to be extracted, in any case
+        [ -d "${addon}" ] && continue || true
---
But that would not work if CT-NG has a feature to force overwriting
extractions, and it would not be possible for do_libc_get() as the glibc has
not yet been extracted when this function is invoked.

Hence, the only solution is perhaps to create a list of built-in add-ons for
each version of (e)glibc.

What do you think?

Best regards,
Benoît

--
For unsubscribe information see http://sourceware.org/lists.html#faq