[PATCH] Stripping toolchain, strip gccbug

[Arnaud Lacombe]

Hi,

On Sat, Mar 19, 2011 at 4:52 PM, Yann E. MORIN
<yann.morin.1998@anciens.enib.fr> wrote:
> Kyle, All,
>
> On Saturday 19 March 2011 20:09:52 Kyle Grieb wrote:
>> Stripping fails when running strip on any: 'POSIX shell script, ASCII text
>> executable'
>
This was not the purpose of the patch, but anyway, could the `gccbug'
script be purely discarded ? The needed infrastructure is no longer in
place on gcc server. It has been killed in 4.6 (cf r165613).

 - Arnaud

>>diff -r 805e9f2a06fa -r 3dedc8edcc32 scripts/build/internals.sh
>>--- a/scripts/build/internals.sh       Mon Mar 14 22:16:01 2011 +0100
>>+++ b/scripts/build/internals.sh       Fri Mar 18 23:55:03 2011 -0500
>>@@ -30,11 +30,9 @@
>>         ; do
>>             _type="$( file "${_t}" |cut -d ' ' -f 2- )"
>>             case "${_type}" in
>>-                *"script text executable")
>>-                    ;;
>>-                *executable*)
>>-                    CT_DoExecLog ALL ${CT_HOST}-strip ${strip_args} "${_t}"
>>-                    ;;
>>+                *"script text executable") ;;
>
> Gratuitous reformating.
> Please avoid formatting changes in the same patch as a functional change.
>
>>+                POSIX*) ;;
>
> No, we really want to avoid _scripts_. POSIX is not sufficient to decide
> whther this is a script.
>
>>+                *executable*) CT_DoExecLog ALL ${CT_HOST}-strip ${strip_args} "${_t}" ;;
>
> Gratuitous reformating. Ditto above.
>
>>             esac
>>         done
>>         CT_Popd
>
> What about this patch, instead?
>
> diff --git a/scripts/build/internals.sh b/scripts/build/internals.sh
> --- a/scripts/build/internals.sh
> +++ b/scripts/build/internals.sh
> @@ -30,7 +30,7 @@
>         ; do
>             _type="$( file "${_t}" |cut -d ' ' -f 2- )"
>             case "${_type}" in
> -                *"script text executable")
> +                *script*executable)
>                     ;;
>                 *executable*)
>                     CT_DoExecLog ALL ${CT_HOST}-strip ${strip_args} "${_t}"
>
> Regards,
> Yann E. MORIN.
>
> --
> .-----------------.--------------------.------------------.--------------------.
> |  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
> | +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
> | +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
> | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
> '------------------------------^-------^------------------^--------------------'
>
> --
> For unsubscribe information see http://sourceware.org/lists.html#faq
>
>

--
For unsubscribe information see http://sourceware.org/lists.html#faq