[PATCH 1 of 2] cross-gdb: add XML support
Yann E. MORIN
yann.morin.1998@anciens.enib.fr
Fri Jun 3 22:19:00 GMT 2011
Benoit, Bryan, All,
On Friday 03 June 2011 23:45:53 Benoît THÉBAUDEAU wrote:
> > 2) Add a *_prepare function to the API, that gets call at the very
> > beginning
> > of the build, and does the necessary checks. Eg.:
> > do_debug_gdb_prepare() {
> > if [ ! "${libexpat_available}" ]; then
> > Aaargh
> > fi
> > }
> > Do it everywhere.
No, the above is crap ( I can say, I wrote it! :-) ). Since I wrote that,
we now have ./configure that can pass options down to kconfig. Let's
use that.
> > Also, have ./configure do the has_or_warn (as per Bryan's
> > suggestion).
> > This is pretty nice, and lightweight. Rather easy to implement, I
> > think.
>
> The has_or_warn part() of my new patch is ready. Do you prefer the
> do_debug_gdb_prepare() that you proposed above, or rather something
> like the following?
>
> ---
> comment "Cross-gdb - disabled (requires expat)"
> depends on !CONFIGURE_has_expat
Although a comment is a very nice thing to have, I am wondering if it
won't come poluting the code. When I first read it, I was all:
Oh, a comment. Very nice!
And then, thinking again, I'm all:
Wait... Will we have to add such a comment for all features
conditional on ./configure ? Can we do it in a generic way ?
And then, how do we tell the user to re-run ./configure again so that
the feat is available? Comments can not have help entries (I just
tested). Seems I'll be hanging on the linux-kbuild list a litle
while longer! ;-)
Let's keep the comment for now. If the ./configure warning is explicit
enough, we can live with that.
> cconfig GDB_CROSS
> bool
> prompt "Cross-gdb"
> default y
> depends on CONFIGURE_has_expat
> select GDB_GDBSERVER if ! BARE_METAL
> help
> Build and install a cross-gdb for the target, to run on host.
> ---
>
> I don't see the point of allowing the user to choose a configuration
> that will fail as soon as the build starts.
Yes, please go ahead as above, comment included.
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
--
For unsubscribe information see http://sourceware.org/lists.html#faq
More information about the crossgcc
mailing list