[CT-NG:patch 06/19] Update CT_DoSaveState and CT_DoRestoreState to check for existence

[Arnaud Lacombe]

On Mon, Apr 12, 2010 at 8:28 AM, Bart van der Meulen
<bartvdrmeulen@gmail.com> wrote:
> Yann, All
>
> 2010/4/11 Yann E. MORIN <yann.morin.1998@anciens.enib.fr>:
>>
>> Let's just save/restore:
>> - the prefix directory (where things get installed): CT_PREFIX_DIR
>> - the build directory in its entirety: CT_BUILD_DIR
>>
>> That makes things much much more easy.
>>
>> Care to change your patch to this effect?
>>
>
> The CT_PREFIX_DIR is already being saved and restored, about saving the
> complete CT_BUILD_DIR I'm not sure.
>
> I think that saving the complete CT_BUILD_DIR is to much, ...
>
I'd tend to agree on that point [thought I didn't read the code..
yet]. Having a more tighter state saving policy would avoid spending
the end of the build saving and restoring context if a step has
nothing to do.

Moreover, that would fix the libc issue, which is if `cc' fails, the
`libc-finish' will fail to restart as ${CT_BUILD_DIR}/build-libc would
have been removed. I have a quick and dirty patch, but its well...
dirty.

 - Arnaud

--
For unsubscribe information see http://sourceware.org/lists.html#faq