[PATCH] use eglibc configuration file

[Yann E. MORIN]

Hello Arnaud!
All,

On Thursday 08 October 2009 18:48:41 Arnaud Vrac wrote:
> Here is a patch to crosstool-ng to add support for a user provided 
> eglibc configuration file. This allows to configure option groups, and 
> nsswitch functions and config files if wanted.

Very nice! I'm glad someone take care to look into that!

> diff -r 8d386988dcb1 config/libc/eglibc.in
> --- a/config/libc/eglibc.in     Sun Oct 04 12:53:12 2009 +0200
> +++ b/config/libc/eglibc.in     Tue Oct 06 18:26:51 2009 +0200

Next time, could you provide a patch that is ready to import into
Mercurial? That has many advantages:
- for me:
  - I can easily import the patch
  - it keeps ancestry of the patch
- for you:
  - it is easy to send the patch
  - it keeps your "username" for the changeset (Or I'd have to do it
    by hand, and am enclined to forget doing so)

You can look in the README, there is a section titled "CONTRIBUTING".

> @@ -90,3 +90,39 @@
>
>        Note that crosstool-NG will *not* update your working copy, you will
>        have to do that yourself.
> +
> +config EGLIBC_USE_CUSTOM_CONFIG
> +    bool
> +    prompt "use user provided configuration file"
> +    default n
> +    help
> +      Use a custom configuration file to disable some features in the eglibc
> +      library. For more info read the EGLIBC.option-groups file in the eglibc
> +      source directory. 
> +
> +if EGLIBC_USE_CUSTOM_CONFIG
> +    config EGLIBC_OPTION_GROUPS_FILE
> +        string
> +        prompt "Option groups configuration file"
> +        default ""
> +        help
> +          Path to the file to configure eglibc option groups.

If I understand correctly, this file contains the options to enable/disable.

> +    config EGLIBC_NSS_CONFIG_FILE
> +        string
> +        prompt "NSS config file"
> +        default ""
> +        help
> +          Path to the nsswitch configuration file when the
> +          OPTION_EGLIBC_NSSWITCH feature is disabled in the option groups
> +          configuration file.

So what is this file for? I don't know why I should have an NSS config file
if I specifically _disabled_ NSS. The help entry is confusing.

> +    config EGLIBC_NSS_FUNCTIONS_FILE
> +        string
> +        prompt "NSS functions file"
> +        default ""
> +        help
> +          Path to the nsswitch functions file when the
> +          OPTION_EGLIBC_NSSWITCH feature is disabled in the option groups
> +          configuration file.
> +endif

What are those NSS functions file, and where is one supposed to find it?

> diff -r 8d386988dcb1 scripts/build/libc/eglibc.sh
> --- a/scripts/build/libc/eglibc.sh      Sun Oct 04 12:53:12 2009 +0200
> +++ b/scripts/build/libc/eglibc.sh      Tue Oct 06 18:26:51 2009 +0200

This hunk is OK.

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
`------------------------------^-------^------------------^--------------------'



--
For unsubscribe information see http://sourceware.org/lists.html#faq