[CT_NG] support for powerpc
Yann E. MORIN
yann.morin.1998@anciens.enib.fr
Sat May 17 11:01:00 GMT 2008
Daniel,
On Saturday 17 May 2008 10:58:44 Dittmann, Daniel wrote:
> I attached a patch to add powerpc support in crosstool-ng.
> Could you please make a short review because it my first patch.
The structure is OK.
Did it build a toolchain?
Was the toolchain functional?
Did you boot a kernel built with that toolchain?
Some userland?
See other comments in-lined below...
> diff -Naur crosstool-ng-1.0.0.orig/arch/powerpc/config.in crosstool-ng-1.0.0/arch/powerpc/config.in
Please, rediff against 1.1.1 or better yet, against svn HEAD.
> --- crosstool-ng-1.0.0.orig/arch/powerpc/config.in 1970-01-01 01:00:00.000000000 +0100
> +++ crosstool-ng-1.0.0/arch/powerpc/config.in 2008-04-14 10:15:54.000000000 +0200
> @@ -0,0 +1 @@
> +# powerpc specific configuration file
No PPC specific option?
What about ppc64?
> diff -Naur crosstool-ng-1.0.0.orig/arch/powerpc/functions crosstool-ng-1.0.0/arch/powerpc/functions
> --- crosstool-ng-1.0.0.orig/arch/powerpc/functions 1970-01-01 01:00:00.000000000 +0100
> +++ crosstool-ng-1.0.0/arch/powerpc/functions 2008-03-28 15:45:51.000000000 +0100
> @@ -0,0 +1,9 @@
> +# Compute powerpc-specific values
> +
> +CT_DoArchValues () {
> + # The architecture part of the tuple:
> + CT_TARGET_ARCH="${CT_ARCH}"
PowerPC can work in big and little endian. How do we set that in the target
tuple?
> +
> + # The kernel ARCH:
> + CT_KERNEL_ARCH=powerpc
What's the difference in the kernel between 'ppc' and 'powerpc', as both
exist?
> +}
> diff -Naur crosstool-ng-1.0.0.orig/config/target.in crosstool-ng-1.0.0/config/target.in
> --- crosstool-ng-1.0.0.orig/config/target.in 2008-01-16 23:06:15.000000000 +0100
> +++ crosstool-ng-1.0.0/config/target.in 2008-03-27 11:12:46.000000000 +0100
> @@ -9,6 +9,7 @@
> default "arm" if ARCH_ARM
> default "ia64" if ARCH_IA64
> default "mips" if ARCH_MIPS
> + default "powerpc" if ARCH_PPC
> default "sh" if ARCH_SH
> default "x86" if ARCH_x86
> default "x86_64" if ARCH_x86_64
> @@ -30,6 +31,10 @@
> depends on EXPERIMENTAL
> select ARCH_SUPPORTS_BOTH_ENDIAN
>
> +config ARCH_PPC
> + bool
> + prompt "powerpc"
PowerPC can work in big and little endian. Select ARCH_SUPPORTS_BOTH_ENDIAN.
> +
> config ARCH_SH
> bool
> prompt "sh (EXPERIMENTAL)"
> @@ -92,6 +97,9 @@
> if ARCH_MIPS
> source config/arch/mips/config.in
> endif
> +if ARCH_PPC
> +source config/arch/powerpc/config.in
> +endif
> if ARCH_SH
> source config/arch/sh/config.in
> endif
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +0/33 662376056 | Software Designer | \ / CAMPAIGN | ^ |
| --==< °_° >==-- °------------.-------: X AGAINST | /e\ There is no |
| http://ymorin.is-a-geek.org/ | * _ * | / \ HTML MAIL | """ conspiracy. |
°------------------------------°-------°------------------°--------------------°
--
For unsubscribe information see http://sourceware.org/lists.html#faq
More information about the crossgcc
mailing list