Two patches for iwmmxt target in glibc

Dan Kegel dank@kegel.com
Tue Aug 3 16:36:00 GMT 2004


Luca Piccarreta wrote:
> Hi Dan.
> I'm not much into gcc development, so I really if this is the correct way
> to submit patches.
> These patches fix a problem with fstat64 and mmap functions in glibc in
> gcc for iwmmxt target.
> This is due to the different ABI between userland and kernel space.
> Kernel sticks to the classic ABI (armv5te or similar), while userland
> programs use the new ABI (it should be calles EABI or something like
> that) because of 64 bit (wireless MMX) support in the processor.
> Without these patches, gcc gets confused by long longs aligned to 4
> bytes (old convention) by the kernel, expecting them to be aligned to
> 8 bytes.

Thanks very much!

I think the thing to do would be to submit them to the glibc-alpha
mailing list, once you've verified that they apply to glibc from cvs,
and that they shouldn't hurt other chips.
It'll be interesting to see what the glibc maintainers say.
If they accept it into CVS, I'll grab it from there.

Please don't say in your post that "Dan told you to do it"; simply give an
example of the problem it's designed to fix, and if possible, give a URL
for the definition of the ABI you're trying to follow.
Also, when you submit them, do it not as a mime attachment, but
include the patch in the body of the email.  Use one email per
patch, with subject line like "[PATCH] Fix stat alignment for arm-iwmmxt".
Finally, you'll want to put a Changelog entry in the post before the
patch; follow the example of other posts to glibc-alpha.
(See http://sources.redhat.com/glibc/)

Thanks!
- Dan

-- 
My technical stuff: http://kegel.com
My politics: see http://www.misleader.org for examples of why I'm for regime change

------
Want more information?  See the CrossGCC FAQ, http://www.objsw.com/CrossGCC/
Want to unsubscribe? Send a note to crossgcc-unsubscribe@sources.redhat.com



More information about the crossgcc mailing list