cluster: RHEL5 - gfs_fsck: Segfault in EA leaf repair

[Bob Peterson]

Gitweb:        http://git.fedorahosted.org/git/cluster.git?p=cluster.git;a=commitdiff;h=8df780b532e02acef7f0ebc0113cf96515a7a3b6
Commit:        8df780b532e02acef7f0ebc0113cf96515a7a3b6
Parent:        70dbc6a16de5c2f84ca08c6957f9178fcba3d80d
Author:        Bob Peterson <rpeterso@redhat.com>
AuthorDate:    Wed Jul 1 14:34:17 2009 -0500
Committer:     Bob Peterson <rpeterso@redhat.com>
CommitterDate: Wed Jul 1 14:34:17 2009 -0500

gfs_fsck: Segfault in EA leaf repair

bz 495774 / 507775
---
 gfs/gfs_fsck/metawalk.c |    7 ++++---
 1 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/gfs/gfs_fsck/metawalk.c b/gfs/gfs_fsck/metawalk.c
index 3279266..2da494d 100644
--- a/gfs/gfs_fsck/metawalk.c
+++ b/gfs/gfs_fsck/metawalk.c
@@ -423,10 +423,11 @@ static int check_leaf_eattr(struct fsck_inode *ip, uint64_t block,
 			relse_buf(ip->i_sbd, bh);
 			return 1;
 		}
-		check_eattr_entries(ip, bh, pass);
-
-		if (bh)
+		if (bh) {
+			error = check_eattr_entries(ip, bh, pass);
 			relse_buf(ip->i_sbd, bh);
+		}
+		return error;
 	}
 
 	return 0;