gfs1-utils: master - gfs_fsck: Segfault in EA leaf repair

Bob Peterson rpeterso@fedoraproject.org
Wed Jul 1 19:49:00 GMT 2009


Gitweb:        http://git.fedorahosted.org/git/gfs1-utils.git?p=gfs1-utils.git;a=commitdiff;h=6ec6f79ce2b87d3d53efea9074f16339e4e66f2c
Commit:        6ec6f79ce2b87d3d53efea9074f16339e4e66f2c
Parent:        fb264df3f0a1932a892a49bf8967da6e4fc613b2
Author:        Bob Peterson <rpeterso@redhat.com>
AuthorDate:    Wed Jul 1 14:34:17 2009 -0500
Committer:     Bob Peterson <rpeterso@redhat.com>
CommitterDate: Wed Jul 1 14:48:37 2009 -0500

gfs_fsck: Segfault in EA leaf repair

bz 495774 / 507775
---
 gfs/gfs_fsck/metawalk.c |    7 ++++---
 1 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/gfs/gfs_fsck/metawalk.c b/gfs/gfs_fsck/metawalk.c
index 104ab7e..b797cca 100644
--- a/gfs/gfs_fsck/metawalk.c
+++ b/gfs/gfs_fsck/metawalk.c
@@ -411,10 +411,11 @@ static int check_leaf_eattr(struct fsck_inode *ip, uint64_t block,
 			relse_buf(ip->i_sbd, bh);
 			return 1;
 		}
-		check_eattr_entries(ip, bh, pass);
-
-		if (bh)
+		if (bh) {
+			error = check_eattr_entries(ip, bh, pass);
 			relse_buf(ip->i_sbd, bh);
+		}
+		return error;
 	}
 
 	return 0;



More information about the Cluster-cvs mailing list