cluster: RHEL4 - rgmanager: Fix stop/start race

Lon Hohberger lon@fedoraproject.org
Mon Jun 15 18:29:00 GMT 2009


Gitweb:        http://git.fedorahosted.org/git/cluster.git?p=cluster.git;a=commitdiff;h=69249ff719a7f3ee2a6addbdcd2d31fc2a0c1ee1
Commit:        69249ff719a7f3ee2a6addbdcd2d31fc2a0c1ee1
Parent:        d1165e1139c3264b037eb494b137132d95f09cb0
Author:        Lon Hohberger <lhh@redhat.com>
AuthorDate:    Mon Jun 15 14:18:36 2009 -0400
Committer:     Lon Hohberger <lhh@redhat.com>
CommitterDate: Mon Jun 15 14:27:41 2009 -0400

rgmanager: Fix stop/start race

If a thread exits right as rgmanager gets a request
to start a new thread, there's a chance that the
the starting thread will incorrectly have a reference
to the old thread and not retry, causing an infinite
loop.

Resolves Bugzilla # 502872

Signed-off-by: Lon Hohberger <lhh@redhat.com>
---
 rgmanager/src/daemons/rg_thread.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/rgmanager/src/daemons/rg_thread.c b/rgmanager/src/daemons/rg_thread.c
index e96982b..c1d6140 100644
--- a/rgmanager/src/daemons/rg_thread.c
+++ b/rgmanager/src/daemons/rg_thread.c
@@ -500,6 +500,7 @@ spawn_if_needed(const char *resgroupname)
 	resthread_t *resgroup = NULL;
 
 retry:
+	resgroup = NULL;
 	pthread_mutex_lock(&reslist_mutex);
 	while (resgroup == NULL) {
 		resgroup = find_resthread_byname(resgroupname);



More information about the Cluster-cvs mailing list