cluster: RHEL5 - rgmanager: randomize ASEHAagent temp files even more

Lon Hohberger lon@fedoraproject.org
Thu May 21 14:29:00 GMT 2009


Gitweb:        http://git.fedorahosted.org/git/cluster.git?p=cluster.git;a=commitdiff;h=eb922807d65d728ff2896470e8133d9308ba1ae4
Commit:        eb922807d65d728ff2896470e8133d9308ba1ae4
Parent:        f47209ebbb923051c4f947f7e933f9e7bf48ff56
Author:        Fabio M. Di Nitto <fdinitto@redhat.com>
AuthorDate:    Thu Oct 30 10:18:19 2008 +0100
Committer:     Lon Hohberger <lhh@redhat.com>
CommitterDate: Thu May 21 10:27:58 2009 -0400

rgmanager: randomize ASEHAagent temp files even more

f8943d17d4c108d44af7a42ad0fd646d4e75990e didn't didn't introduce enough
security.

Switch to mktemp(1).

Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>
---
 rgmanager/src/resources/ASEHAagent.sh |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/rgmanager/src/resources/ASEHAagent.sh b/rgmanager/src/resources/ASEHAagent.sh
index 35f3fa1..ddf52c9 100755
--- a/rgmanager/src/resources/ASEHAagent.sh
+++ b/rgmanager/src/resources/ASEHAagent.sh
@@ -781,8 +781,8 @@ deep_probe()
 	ocf_log debug "ASEHAagent: Start 'deep_probe'."	
 
 	# Declare two temporary files which will be used in this probe.
-	tmpfile1="/tmp/ASEHAagent.1.$$"
-	tmpfile2="/tmp/ASEHAagent.2.$$"
+	tmpfile1="$(mktemp -t /tmp/ASEHAagent.1.XXXXXX)"
+	tmpfile2="$(mktemp -t /tmp/ASEHAagent.2.XXXXXX)"
 	
 	# Get the login_string by analyzing the login_file.
 	get_login_string



More information about the Cluster-cvs mailing list