cluster: RHEL4 - rgmanager: Fix segfault from missing initializers

Lon Hohberger lon@fedoraproject.org
Wed Apr 8 21:01:00 GMT 2009


Gitweb:        http://git.fedorahosted.org/git/cluster.git?p=cluster.git;a=commitdiff;h=6cc6d11249bac6ff21839b96cd924655892d68ee
Commit:        6cc6d11249bac6ff21839b96cd924655892d68ee
Parent:        719b4c225faa87ac4e61127612b53ad0fd648a98
Author:        Lon Hohberger <lhh@redhat.com>
AuthorDate:    Wed Apr 8 16:49:04 2009 -0400
Committer:     Lon Hohberger <lhh@redhat.com>
CommitterDate: Wed Apr 8 17:00:05 2009 -0400

rgmanager: Fix segfault from missing initializers

If the sets are empty or malloc fails, there is
a chance that the set lengths will not be zero
like they should, causing a segfault.

Only happens w/ previous patch for bug #428108

Signed-off-by: Lon Hohberger <lhh@redhat.com>
---
 rgmanager/src/daemons/groups.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/rgmanager/src/daemons/groups.c b/rgmanager/src/daemons/groups.c
index a0816d5..f26c0d4 100644
--- a/rgmanager/src/daemons/groups.c
+++ b/rgmanager/src/daemons/groups.c
@@ -435,9 +435,9 @@ check_rdomain_crash(char *svcName)
 	set_type_t *nodes = NULL;
 	set_type_t *fd_nodes = NULL;
 	set_type_t *isect = NULL;
-	int nodecount;
-	int fd_nodecount, fl;
-	int icount;
+	int nodecount = 0;
+	int fd_nodecount = 0, fl = 0;
+	int icount = 0;
 	char fd_name[256];
 
 	if (group_property(svcName, "domain", fd_name, sizeof(fd_name)) != 0)



More information about the Cluster-cvs mailing list