cluster: master - build: stricter install invokation

Fabio M. Di Nitto fabbione@fedoraproject.org
Wed Feb 25 10:09:00 GMT 2009


Gitweb:        http://git.fedorahosted.org/git/cluster.git?p=cluster.git;a=commitdiff;h=9dafa385dab9d04bf14843e83515a7b92a7198d5
Commit:        9dafa385dab9d04bf14843e83515a7b92a7198d5
Parent:        e6348b362ac082f0965744bc11134ba22f57b8f1
Author:        Fabio M. Di Nitto <fdinitto@redhat.com>
AuthorDate:    Fri Feb 20 06:53:24 2009 +0100
Committer:     Fabio M. Di Nitto <fdinitto@redhat.com>
CommitterDate: Wed Feb 25 11:09:11 2009 +0100

build: stricter install invokation

make install fails in shell loops to detect errors.

Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>
---
 make/install.mk |    4 ++++
 make/man.mk     |    2 ++
 2 files changed, 6 insertions(+), 0 deletions(-)

diff --git a/make/install.mk b/make/install.mk
index 8671618..a893288 100644
--- a/make/install.mk
+++ b/make/install.mk
@@ -8,6 +8,7 @@ ifdef LIBSYMT
 endif
 ifdef INCDIRT
 	install -d ${incdir}
+	set -e; \
 	for i in ${INCDIRT}; do \
 		install -m644 $(S)/$$i ${incdir}; \
 	done
@@ -31,6 +32,7 @@ ifdef LCRSOT
 endif
 ifdef INITDT
 	install -d ${initddir}
+	set -e; \
 	for i in ${INITDT}; do \
 		if [ -f $$i ]; then \
 			install -m755 $$i ${initddir}; \
@@ -41,12 +43,14 @@ ifdef INITDT
 endif
 ifdef UDEVT
 	install -d ${DESTDIR}/etc/udev/rules.d
+	set -e; \
 	for i in ${UDEVT}; do \
 		install -m644 $(S)/$$i ${DESTDIR}/etc/udev/rules.d; \
 	done
 endif
 ifdef DOCS
 	install -d ${docdir}
+	set -e; \
 	for i in ${DOCS}; do \
 		install -m644 $(S)/$$i ${docdir}; \
 	done
diff --git a/make/man.mk b/make/man.mk
index b43efc1..26f6401 100644
--- a/make/man.mk
+++ b/make/man.mk
@@ -1,6 +1,7 @@
 all:
 
 install:
+	set -e; \
 	for i in ${TARGET}; do \
 		p=`echo $$i | sed -e 's#.*\.##g'`; \
 		install -d ${mandir}/man$$p; \
@@ -8,6 +9,7 @@ install:
 	done
 
 uninstall:
+	set -e; \
 	for i in ${TARGET}; do \
 		p=`echo $$i | sed -e 's#.*\.##g'`; \
 		${UNINSTALL} $$i ${mandir}/man$$p; \



More information about the Cluster-cvs mailing list