resource-agents: master - [RGMANAGER] Resolves: #474444 - Zero-length pid files cause resource start failures

Marek Grác marx@fedoraproject.org
Tue Jan 20 20:03:00 GMT 2009


Gitweb:        http://git.fedorahosted.org/git/resource-agents.git?p=resource-agents.git;a=commitdiff;h=08b1eedc15ba74fe8ba2785393ab21d299fbfd2b
Commit:        08b1eedc15ba74fe8ba2785393ab21d299fbfd2b
Parent:        75ec13c4df9b18b2d114660fd290ddb023249ffd
Author:        Marek 'marx' Grac <mgrac@redhat.com>
AuthorDate:    Tue Jan 20 21:01:10 2009 +0100
Committer:     Marek 'marx' Grac <mgrac@redhat.com>
CommitterDate: Tue Jan 20 21:01:10 2009 +0100

[RGMANAGER] Resolves: #474444 - Zero-length pid files cause resource start failures

---
 rgmanager/src/resources/utils/config-utils.sh.in |    8 ++++++++
 1 files changed, 8 insertions(+), 0 deletions(-)

diff --git a/rgmanager/src/resources/utils/config-utils.sh.in b/rgmanager/src/resources/utils/config-utils.sh.in
index b5fcf84..4ee083f 100644
--- a/rgmanager/src/resources/utils/config-utils.sh.in
+++ b/rgmanager/src/resources/utils/config-utils.sh.in
@@ -218,6 +218,14 @@ check_pid_file() {
 		return 0;
 	fi
 
+	## if PID file is empty then it should be safe to remove it
+	read pid < "$pid_file"
+	if [ -z "$pid" ]; then
+		rm $pid_file
+		ocf_log debug "PID File \"$pid_file\" Was Removed - Zero length";
+		return 0;
+	fi
+
 	if [ ! -d /proc/`cat "$pid_file"` ]; then	
 		rm "$pid_file"
 		ocf_log debug "PID File \"$pid_file\" Was Removed - PID Does Not Exist";



More information about the Cluster-cvs mailing list