[PATCH] master.cfg: Do not fail the build if tentative "chmod -R u+w" fails in libabigail_mt_combo_steps

Mark Wielaard mark@klomp.org
Thu Sep 3 14:45:27 GMT 2026


Hi Dodji,

On Thu, 2026-09-03 at 16:34 +0200, Dodji Seketeli wrote:
> But then, we can also just fix it already.
> 
> Please find below an updated patch that does just that.  Many thanks!

Thanks, pushed with one tiny tweak.

> diff --git a/builder/master.cfg b/builder/master.cfg
> index 607035e..4485192 100644
> --- a/builder/master.cfg
> +++ b/builder/master.cfg
> @@ -5032,7 +5032,7 @@ def libabigail_mt_combo_steps(build_name, configure_extra, tagsuffix):
>                  command=["chmod", "-R", "u+w",
>                           util.Interpolate("%(prop:builddir)s/" + build_name)],
>                  name="chmod u+w pre removing left-overs " + build_name,
> -                haltOnFailure=False))
> +                haltOnFailure=False, flunkOnFailure=False))
>          s.append(steps.ShellCommand(
>                  command=["rm", "-rf",
>                           util.Interpolate("%(prop:builddir)s/" + build_name)],
> @@ -5083,7 +5083,7 @@ def libabigail_mt_combo_steps(build_name, configure_extra, tagsuffix):
>                  command=["chmod", "-R", "u+w",
>                           util.Interpolate("%(prop:builddir)s/" + build_name)],
>                  name="chmod u+w after bunsen/distcheck",
> -                haltOnFailure=False))
> +                haltOnFailure=False, flunkOnFailure=False,))

The trailing , is valid syntax, but it annoyed me that the two commands
looked different. So I removed it.

Cheers,

Mark


More information about the Buildbot mailing list