[PATCH] master.cfg: Add missing "chmod -R u+w $(builddir)" to libabigail_mt_combo_steps

Mark Wielaard mark@klomp.org
Thu Sep 3 11:12:11 GMT 2026


Hi Dodji,

On Thu, 2026-09-03 at 11:55 +0200, Dodji Seketeli wrote:
> Mark Wielaard <mark@klomp.org> a écrit:
> > But buildbot checkconfig builder gives some errors for me:
> > 
> > Configuration Errors:
> >   Step ShellCommand name 'chmod u+w before removing left-overs with rm -rf build-mt' exceeds maximum length of 50
> >   Step ShellCommand name 'chmod u+w before removing left-overs with rm -rf build-mtasan' exceeds maximum length of 50
> >   Step ShellCommand name 'chmod u+w before removing left-overs with rm -rf build-mttsan' exceeds maximum length of 50
> > 
> > Could you reduce the name a bit?
> 
> Sure.  Below is an updated patch:
> 
> From 78d24c1c9473f6c23f0f30eaa18e0f7cb72db633 Mon Sep 17 00:00:00 2001
> From: Dodji Seketeli <dodji@seketeli.org>
> Date: Thu, 3 Sep 2026 09:10:24 +0200
> Subject: [PATCH] master.cfg: Add missing "chmod -R u+w $(builddir)" to libabigail_mt_combo_steps
> 
> When setting up the multithreading build environment for Libabigail,
> libabigail_mt_combo_steps starts by removing the potential left-overs
> from the build directory it intends to populates.
> 
> Sometimes, that build directory has read-only access.  That leads to
> an error whenever libabigail_mt_combo_steps tries to remove it.
> 
> libabigail_mt_combo_steps thus needs to make it have writable access
> before attempting to remove it, just like what is done at cleanup
> time, at the end of the function.
> 
> This patch does just that.

Pushed,

Mark

> Signed-off-by: Dodji Seketeli <dodji@seketeli.org>
> ---
>  builder/master.cfg | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/builder/master.cfg b/builder/master.cfg
> index cd8a1a3..607035e 100644
> --- a/builder/master.cfg
> +++ b/builder/master.cfg
> @@ -5028,6 +5028,11 @@ libabigail_euts_install_step = steps.Compile(
>  def libabigail_mt_combo_steps(build_name, configure_extra, tagsuffix):
>          """One mt configure/build/check/distcheck/bunsen cycle in a sibling dir."""
>          s = []
> +        s.append(steps.ShellCommand(
> +                command=["chmod", "-R", "u+w",
> +                         util.Interpolate("%(prop:builddir)s/" + build_name)],
> +                name="chmod u+w pre removing left-overs " + build_name,
> +                haltOnFailure=False))
>          s.append(steps.ShellCommand(
>                  command=["rm", "-rf",
>                           util.Interpolate("%(prop:builddir)s/" + build_name)],
> -- 
> 2.55.0
> 
> 
> Cheers,


More information about the Buildbot mailing list