[PATCH] master.cfg: Add --prefix to libabigail multithreading configure options

Dodji Seketeli dodji@seketeli.org
Thu Aug 27 15:31:14 GMT 2026


Hello Mark,

Mark Wielaard <mark@klomp.org> a écrit:

[...]

Mark Wielaard <mark@klomp.org> a écrit

>> > So like with the previous patch, why do you need both --prefix and --
>> > with-... ? Isn't --prefix normally used for where libabigail itself is
>> > installed?

Dodji Seketeli wrote:

>> Good question.  And you are right, yes, normally, that's how it's
>> supposed to be used, I guess.  Today, however, the configure script
>> looks for elfutil's header files in $prefix/include.

Mark Wielaard <mark@klomp.org> a écrit

> OK. But that really should be cleaned up imho.

I'll do.

> Likewise for using setting LD_LIBRARY_PATH and PKG_CONFIG_PATH in the
> previous patch. Is that really necessary, if so why and can you handle
> that in the libabigail configure/build? 

Ah.  Neither LD_LIBRARY_PATH nor PKG_CONFIG_PATH are necessary.  Their
usage can indeed be removed, I think.

Mark Wielaard <mark@klomp.org> a écrit

> I would name it --with-elfutils= (but am also fine with separate --
> with-libdw and --with-libelf). Naming doesn't really matter.

I'll go with --with-elfutils= then.  Thanks!

I'll then send a separate patch to master.cfg to make both ends match.

Thanks!

Cheers,

-- 
		Dodji


More information about the Buildbot mailing list